Messages in this thread | | | Date | Fri, 5 Feb 2010 14:55:20 -0600 (CST) | From | Christoph Lameter <> | Subject | Re: [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues |
| |
On Fri, 5 Feb 2010, Andi Kleen wrote:
> > It changes the bootstrap semantics. The requirement was so far that slab > > initialization must be complete before slab operations can be used. > > The problem is that slab itself uses slab it initialize itself.
slab uses itself and also the page allocator to bootstrap itself. The sequence was always a bit fragile. The page allocator also needs to use the slab allocator in turn to bootstrap itself.
> > This patchset allows such use before bootstrap on a node is complete and > > also allows the running of cache reaper before bootstrap is done. > > > > I have a bad feeling that this could be the result of Pekka's changes to > > the bootstrap. > > Not sure I fully follow what you're saying. > > Are you saying this is a regression fix after all?
I am saying that we may have more trouble lurking here.
If we fix it this way then the bootstrap of a node is different from system bootstrap that so far does not need these special measures.
| |