lkml.org 
[lkml]   [2010]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [46/74] net: restore ip source validation
From
Date
Sven Joachim <svenjoac@gmx.de> writes:

> On 2010-02-05 15:51 +0100, jamal wrote:
>
>> The problem is elsewhere. Here's the fix.
>>
>> --
>> diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
>> index b6e7aae..469193c 100644
>> --- a/kernel/sysctl_check.c
>> +++ b/kernel/sysctl_check.c
>> @@ -220,6 +220,7 @@ static const struct trans_ctl_table
>> trans_net_ipv4_conf_vars_table[] = {
>> { NET_IPV4_CONF_PROMOTE_SECONDARIES, "promote_secondaries" },
>> { NET_IPV4_CONF_ARP_ACCEPT, "arp_accept" },
>> { NET_IPV4_CONF_ARP_NOTIFY, "arp_notify" },
>> + { NET_IPV4_CONF_SRC_VMARK, "src_valid_mark" },
>> {}
>> };
>> ---
>
> Well spotted, that fixes it. Your mailer is broken however, it
> converted tabs into spaces, so I had to add the changed line manually.

Bah. That DEVINET_SYSCTL_ENTRY requires having a binary sysctl
assigned, just to use as an index.

Which of course trips over all of the fine checks in sysctl_check.c to
keep people from assigning new binary sysctls by accident.

That is the only place in the kernel where he have that problem, I wonder
how much work it will be to finish untangling.

Eric


\
 
 \ /
  Last update: 2010-02-05 21:21    [W:0.036 / U:2.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site