Messages in this thread | | | From | "Lu, Hongjiu" <> | Date | Fri, 5 Feb 2010 11:47:25 -0800 | Subject | RE: [patch] x86: ptrace and core-dump extensions for xstate |
| |
> > On 02/04/2010 02:05 PM, Suresh Siddha wrote: > > > > So in the example you provided before: > > > > struct iovec iov = { mybuffer, mylength }; > > ret = ptrace(PTRACE_GETREGSET, NT_X86_XSTATE, &iov); > > > > You wanted to propose common data format (iov) for all of the NT_* ? > > > > How about encoding the regset number into the command, e.g. > ptrace(PTRACE_GETREGS(NT_X86_XSTATE), length, buffer) > > ... where we have ... > > #define PTRACE_GETREGS(r) (((r) << 16) | PTRACE_GETREGS_CMD) > > ... or something like that? >
I like this idea.
BTW, it should be
ptrace(PTRACE_GETREGS(NT_X86_XSTATE), pid, length, buffer)
H.J.
| |