Messages in this thread | | | Date | Fri, 5 Feb 2010 11:30:20 -0500 | Subject | Re: [PATCH] inotify/fsnotify: tree-watching support | From | Eric Paris <> |
| |
On Fri, Feb 5, 2010 at 8:51 AM, Joris Dolderer <vorstadtkind@googlemail.com> wrote: > Hi, > > This is my first software submit, so please don't spare with detailed > constructive critics and be nice to me ;-).
I would suggest that you take a careful look at Documentation/CodingStyle and Documentation/SubmittingPatches. There appear to be quite a number of issues which you may believe to be purely cosmetic or aesthetic but coding style and proper submission of patches are very important to keeping the kernel easy to maintain and develop further.
I will try to take a look a the contents of the patch over the weekend and will give you some feedback.
Thanks! -Eric
| |