lkml.org 
[lkml]   [2010]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] inotify/fsnotify: tree-watching support
From
On Fri, Feb 5, 2010 at 8:51 AM, Joris Dolderer
<vorstadtkind@googlemail.com> wrote:
> Hi,
>
> This is my first software submit, so please don't spare with detailed
> constructive critics and be nice to me ;-).

I would suggest that you take a careful look at
Documentation/CodingStyle and Documentation/SubmittingPatches. There
appear to be quite a number of issues which you may believe to be
purely cosmetic or aesthetic but coding style and proper submission of
patches are very important to keeping the kernel easy to maintain and
develop further.

I will try to take a look a the contents of the patch over the weekend
and will give you some feedback.

Thanks!
-Eric


\
 
 \ /
  Last update: 2010-02-05 17:33    [W:2.404 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site