Messages in this thread | | | From | Arnaud Patard (Rtp) <> | Subject | Re: [PATCH 1/9] platform-drivers: move probe to .devinit.text in arch/arm | Date | Thu, 04 Feb 2010 22:20:26 +0100 |
| |
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> A pointer to a probe callback is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Arnaud Patard <arnaud.patard@rtp-net.org> > Cc: Ben Dooks <ben-linux@fluff.org> > Cc: Dmitry Baryshkov <dbaryshkov@gmail.com> > Cc: Eric Miao <eric.miao@marvell.com> > Cc: Kristoffer Ericson <Kristoffer.Ericson@gmail.com> > Cc: Liam Girdwood <liam.girdwood@wolfsonmicro.com> > Cc: Paul Sokolovsky <pmiscml@gmail.com> > Cc: Richard Purdie <rpurdie@rpsys.net> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > --- > arch/arm/mach-pxa/corgi_ssp.c | 2 +- > arch/arm/mach-pxa/sharpsl_pm.c | 2 +- > arch/arm/mach-s3c2410/h1940-bluetooth.c | 2 +- > arch/arm/mach-sa1100/jornada720_ssp.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-)
For the h1940-bluetooth change : Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |