lkml.org 
[lkml]   [2010]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 9/9] net: move am79c961's probe function to .devinit.text
    Date
    A pointer to am79c961_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Roel Kluin <12o3l@tiscali.nl>
    Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    Cc: netdev@vger.kernel.org
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    Hello,

    @David Miller: this patch is in patchwork with State: Not Applicable.
    Does that mean that netdev isn't the right tree for this patch?

    Best regards
    Uwe

    drivers/net/arm/am79c961a.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
    index 164b37e..1c3c1f9 100644
    --- a/drivers/net/arm/am79c961a.c
    +++ b/drivers/net/arm/am79c961a.c
    @@ -680,7 +680,7 @@ static const struct net_device_ops am79c961_netdev_ops = {
    #endif
    };

    -static int __init am79c961_probe(struct platform_device *pdev)
    +static int __devinit am79c961_probe(struct platform_device *pdev)
    {
    struct resource *res;
    struct net_device *dev;
    --
    1.6.6
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-04 21:01    [W:0.026 / U:31.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site