lkml.org 
[lkml]   [2010]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[02/74] [SCSI] mptsas: Fix issue with chain pools allocation on katmai
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Anatolij Gustschin <agust@denx.de>

    commit f1053a7ca9ce095d95bcc1cf41684c5e4f3e7751 upstream.

    Since commit 9d2e9d66a3f032667934144cd61c396ba49f090d
    mptsas driver fails to allocate memory for the MPT chain buffers
    for second LSI adapter on PPC440SPe Katmai platform:
    ...
    ioc1: LSISAS1068E B3: Capabilities={Initiator}
    mptbase: ioc1: ERROR - Unable to allocate Reply, Request, Chain Buffers!
    mptbase: ioc1: ERROR - didn't initialize properly! (-3)
    mptsas: probe of 0002:31:00.0 failed with error -3

    This commit increased MPT_FC_CAN_QUEUE value but initChainBuffers()
    doesn't differentiate between SAS and FC causing increased allocation
    for SAS case, too. Later pci_alloc_consistent() fails to allocate
    increased chain buffer pool size for SAS case.

    Provide a fix by looking at the bus type and using appropriate
    MPT_SAS_CAN_QUEUE value while calculation of the number of chain
    buffers.

    Signed-off-by: Anatolij Gustschin <agust@denx.de>
    Acked-by: Kashyap Desai <kashyap.desai@lsi.com>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/message/fusion/mptbase.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/message/fusion/mptbase.c
    +++ b/drivers/message/fusion/mptbase.c
    @@ -4330,6 +4330,8 @@ initChainBuffers(MPT_ADAPTER *ioc)

    if (ioc->bus_type == SPI)
    num_chain *= MPT_SCSI_CAN_QUEUE;
    + else if (ioc->bus_type == SAS)
    + num_chain *= MPT_SAS_CAN_QUEUE;
    else
    num_chain *= MPT_FC_CAN_QUEUE;




    \
     
     \ /
      Last update: 2010-02-04 18:43    [W:0.021 / U:118.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site