lkml.org 
[lkml]   [2010]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 8/9] perf annotate: fix it for non-prelinked *.so
    From
    Date
    On Wed, 2010-02-03 at 16:52 -0200, Arnaldo Carvalho de Melo wrote:
    > const char *path = NULL;
    > @@ -397,7 +397,8 @@ static void annotate_sym(struct hist_entry *he)
    > dso, dso->long_name, sym, sym->name);
    >
    > sprintf(command, "objdump --start-address=0x%016Lx --stop-address=0x%016Lx -dS %s|grep -v %s",
    > - map->unmap_ip(map, sym->start), map->unmap_ip(map, sym->end),
    > + map__rip_2objdump(map, sym->start),
    > + map__rip_2objdump(map, sym->end),
    > filename, filename);
    >

    Monkey see monkey do.

    perf tools: fix perf top module symbol annotation.

    Signed-off-by: Mike Galbraith <efault@gmx.de>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    LKML-Reference: <new-submission>

    ---
    tools/perf/builtin-top.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: linux-2.6/tools/perf/builtin-top.c
    ===================================================================
    --- linux-2.6.orig/tools/perf/builtin-top.c
    +++ linux-2.6/tools/perf/builtin-top.c
    @@ -204,8 +204,8 @@ static void parse_source(struct sym_entr
    sprintf(command,
    "objdump --start-address=0x%016Lx "
    "--stop-address=0x%016Lx -dS %s",
    - map->unmap_ip(map, sym->start),
    - map->unmap_ip(map, sym->end), path);
    + map__rip_2objdump(map, sym->start),
    + map__rip_2objdump(map, sym->end), path);

    file = popen(command, "r");
    if (!file)



    \
     
     \ /
      Last update: 2010-02-04 07:35    [W:0.023 / U:0.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site