Messages in this thread | | | Date | Wed, 3 Feb 2010 13:47:40 +0530 | From | Balbir Singh <> | Subject | Re: [patch] sysctl: clean up vm related variable declarations |
| |
* David Rientjes <rientjes@google.com> [2010-02-02 18:36:42]:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Now, there are many "extern" declaration in kernel/sysctl.c. "extern" > declaration in *.c file is not appreciated in general. > And Hmm...it seems there are a few redundant declarations. > > Because most of sysctl variables are defined in its own header file, > they should be declared in the same style, be done in its own *.h file. > > This patch removes some VM(memory management) related sysctl's > variable declaration from kernel/sysctl.c and move them to > proper places. > > [rientjes@google.com: #ifdef fixlet] > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: David Rientjes <rientjes@google.com> > --- > include/linux/mm.h | 5 +++++ > include/linux/mmzone.h | 1 + > include/linux/oom.h | 5 +++++ > kernel/sysctl.c | 16 ++-------------- > mm/mmap.c | 5 +++++ > 5 files changed, 18 insertions(+), 14 deletions(-) >
Looks good to me
-- Balbir
| |