Messages in this thread | | | Date | Wed, 3 Feb 2010 21:56:09 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] MX1/MX2: -EINVAL overwritten in second iteration in mxc_gpio_setup_multiple_pins() |
| |
On Wed, Feb 03, 2010 at 08:19:00PM +0100, Roel Kluin wrote: > Due to the `ret = gpio_request()' below in the loop, the initial -EINVAL value > of ret is overwritten. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> --- > Not 100% sure this is needed, please review. One more question: is it ok > to return 0 when count is 0 (and nothing is done)? I'd say yes. If you want nothing from me, I can say I gave you all you wanted without doing anything.
Thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |