Messages in this thread | | | Date | Wed, 3 Feb 2010 21:09:54 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/2] exec: refactor how call_usermodehelper works, and update the sense of the core_pipe recursion check (v3) |
| |
On 02/02, Neil Horman wrote: > > +void call_usermodehelper_setfns(struct subprocess_info *info, > + int (*init)(struct subprocess_info *info), > + void (*cleanup)(struct subprocess_info *info), > + void *data); > ... > +call_usermodehelper_fns(char *path, char **argv, char **envp, > + enum umh_wait wait, > + int (*init)(struct subprocess_info *info), > + void (*cleanup)(struct subprocess_info *), void *data) > ... > + call_usermodehelper_setfns(info, init, cleanup, data); > return call_usermodehelper_exec(info, wait); > }
Unless I misread the patch, this is the only caller of _setfns(), and this helper is really trivial and probably deserves to be inline. But this is very minor.
Personally I think these patches are nice. Not only this series adds the new functionality, in my opinion it also cleanups and simplifies the code.
Oleg.
| |