lkml.org 
[lkml]   [2010]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] exec: refactor how call_usermodehelper works, and update the sense of the core_pipe recursion check (v3)
On 02/02, Neil Horman wrote:
>
> +void call_usermodehelper_setfns(struct subprocess_info *info,
> + int (*init)(struct subprocess_info *info),
> + void (*cleanup)(struct subprocess_info *info),
> + void *data);
> ...
> +call_usermodehelper_fns(char *path, char **argv, char **envp,
> + enum umh_wait wait,
> + int (*init)(struct subprocess_info *info),
> + void (*cleanup)(struct subprocess_info *), void *data)
> ...
> + call_usermodehelper_setfns(info, init, cleanup, data);
> return call_usermodehelper_exec(info, wait);
> }

Unless I misread the patch, this is the only caller of _setfns(), and
this helper is really trivial and probably deserves to be inline. But
this is very minor.

Personally I think these patches are nice. Not only this series adds
the new functionality, in my opinion it also cleanups and simplifies
the code.

Oleg.



\
 
 \ /
  Last update: 2010-02-03 21:13    [W:0.229 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site