lkml.org 
[lkml]   [2010]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] kernel-shark: fix unitialized handle compile warnings
    From
    On Wed, Feb 3, 2010 at 5:19 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
    > On Wed, 2010-02-03 at 11:17 -0500, Steven Rostedt wrote:
    >> andle)
    >> > > -               handle = tracecmd_open(input_file);
    >> > > +       handle = tracecmd_open(input_file);
    >> > >
    >> > > -       info->handle = handle;
    >> > > +       if (handle)
    >> > > +               info->handle = handle;
    >> > >
    >> > >        /* --- Main window --- */
    >> > >
    >> > > --
    >> >
    >> > This looks correct, but I'm wondering if it is safe to continue if the
    >> > call to tracecmd_open fails?
    >>
    >> Actually this patch is wrong. The real code should be:
    >>
    >> -     if (handle)
    >> +     if (input_file)
    >
    > Looking at the context, this isn't enough. We should have had:
    >
    >        if (input_file)
    >                info->handle = tracecmd_open(input_file);
    >        else
    >                info->handle = NULL;
    >
    > -- Steve
    >

    Okay, are you going to push it to your repo for us? I would offer to
    push it through mine if it would save you time, but it's probably
    quicker if you just handle it.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-03 17:45    [W:0.023 / U:0.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site