Messages in this thread |  | | | Subject | Re: [PATCH 3/3] kernel-shark: fix unitialized handle compile warnings | | From | Steven Rostedt <> | | Date | Wed, 03 Feb 2010 11:19:05 -0500 |
| |
On Wed, 2010-02-03 at 11:17 -0500, Steven Rostedt wrote: > andle) > > > - handle = tracecmd_open(input_file); > > > + handle = tracecmd_open(input_file); > > > > > > - info->handle = handle; > > > + if (handle) > > > + info->handle = handle; > > > > > > /* --- Main window --- */ > > > > > > -- > > > > This looks correct, but I'm wondering if it is safe to continue if the > > call to tracecmd_open fails? > > Actually this patch is wrong. The real code should be: > > - if (handle) > + if (input_file)
Looking at the context, this isn't enough. We should have had:
if (input_file) info->handle = tracecmd_open(input_file); else info->handle = NULL; -- Steve
|  |