Messages in this thread | | | Date | Wed, 3 Feb 2010 22:33:06 +1100 | Subject | Re: [PATCH] drivers/acpi/ec.c fix a small memory leak | From | Darren Jenkins <> |
| |
Hello Alexey,
On Wed, Feb 3, 2010 at 2:35 AM, Alexey Starikovskiy <astarikovskiy@suse.de> wrote: > NAK > > saved_ec is allocated if flag EC_FLAGS_VALIDATE_ECDT is true. > EC_FLAGS_SKIP_DSDT_SCAN have no sense in such case, thus this new code path > is never executed.
From what I can tell this is not guaranteed by the code, it is relying on DMI data not matching two of the stings at once. However I don't know anything about DMI, so if you say this makes no sense and will never happen I am happy.
I will mark this as ignore in the Coverity databse.
> On the other hand, unconditionally freeing pointer, which is might be NULL, is not > right either.
Nowadays this is the preferred method actually.
> Regards, > Alex.
Thanks for the feedback.
Darren J
| |