lkml.org 
[lkml]   [2010]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap
    On Fri, 26 Feb 2010 18:31:15 +0100
    Andi Kleen <andi@firstfloor.org> wrote:

    > On Fri, Feb 26, 2010 at 11:24:50AM -0600, Christoph Lameter wrote:
    > > On Fri, 26 Feb 2010, Andi Kleen wrote:
    > >
    > > > > > Memory hotplug with node add never quite worked on x86 before,
    > > > > > for various reasons not related to slab.
    > > > >
    > > > > Ok but why did things break in such a big way?
    > > >
    > > > 1) numa memory hotadd never worked
    > >
    > > Well Kamesan indicated that this worked if a cpu became online.
    >
    > I mean in the general case. There were tons of problems all over.
    >
    Then, it's cpu hotplug matter, not memory hotplug.
    cpu hotplug callback should prepaare


    l3 = searchp->nodelists[node];
    BUG_ON(!l3);

    before onlined. Rather than taking care of races.


    Thanks,
    -Kame



    \
     
     \ /
      Last update: 2010-03-01 03:05    [W:0.022 / U:0.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site