lkml.org 
[lkml]   [2010]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/14] dell-laptop: Use buffer with 32-bit physical address
On Fri, Feb 26, 2010 at 10:18:42AM -0500, Matthew Garrett wrote:
> From: Stuart Hayes <stuart_hayes@dell.com>
>
> Calls to communicate with system firmware via a SMI (using dcdbas)
> need to use a buffer that has a physical address of 4GB or less.
> Currently the dell-laptop driver does not guarantee this, and when the
> buffer address is higher than 4GB, the address is truncated to 32 bits
> and the SMI handler writes to the wrong memory address.
>
> Signed-off-by: Stuart Hayes <stuart_hayes@dell.com>
> Acked-by: Matthew Garrett <mjg@redhat.com>
> ---
> drivers/platform/x86/dell-laptop.c | 122 ++++++++++++++++++++++++-----------
> 1 files changed, 83 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index d8b1b39..1a0bfd4 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -22,6 +22,7 @@
> #include <linux/rfkill.h>
> #include <linux/power_supply.h>
> #include <linux/acpi.h>
> +#include <linux/mm.h>
> #include <linux/i8042.h>
> #include "../../firmware/dcdbas.h"
>
> @@ -123,6 +124,21 @@ static struct dmi_system_id __devinitdata dell_blacklist[] = {
> {}
> };
>
> +static struct calling_interface_buffer *buffer;
> +struct page *bufferpage;

static ?

> +DEFINE_MUTEX(buffer_mutex);

static?

--
Dmitry


\
 
 \ /
  Last update: 2010-02-27 09:13    [from the cache]
©2003-2011 Jasper Spaans