lkml.org 
[lkml]   [2010]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [GIT PULL] notification: including fanotify


On Sat, 27 Feb 2010, Linus Torvalds wrote:
>
> (b) the compile has obviously never been tested with any modern gcc
> version. I get tons of warnings after the pull, like

In fact, this seems to be due to a commit that explicitly says:

I do not add -Wpointer-sign to the fsnotify
code as there are still issues with kstrdup and strlen which would pop
out needless warnings.

but then the patch actually has

--- a/fs/notify/Makefile
+++ b/fs/notify/Makefile
@@ -1,3 +1,5 @@
+EXTRA_CFLAGS += -Wpointer-sign
+

WTF? Which part of this was tested AT ALL? Clearly there was not even a
compile test going on.

Linus

\
 
 \ /
  Last update: 2010-02-27 22:37    [W:0.052 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site