Messages in this thread | | | Date | Fri, 26 Feb 2010 12:08:34 +0100 | Subject | Re: [PATCH 0/5] x86-32: improve atomic64_t functions (v2) | From | Luca Barbieri <> |
| |
> FYI, it triggered build failures in -tip testing: > > lib/atomic64_test.c: In function 'test_atomic64': > lib/atomic64_test.c:116: error: implicit declaration of function 'atomic64_dec_if_positive'
This was on x86-64 right?
That function is implemented in the generic atomic64 implementation and my x86-32 version, but not in the x86-64 implementation.
There is a similar problem with the 32-bt atomic_dec_if_positive, that is implemented by ppc, mips, microblaze and avr32 but not in x86-32 and asm-generic. Currently the 64-bit version seems unused, while the 32-bit one seems to be only used by ppc-only drivers (IBM pSeries virtual SCSI and PlayStation3 drivers).
I'll send a couple of patches to fix this shortly.
| |