[lkml]   [2010]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] thinkpad-acpi: fix return value of volume callbacks
    On Tue, 23 Feb 2010, Clemens Ladisch wrote:
    > Henrique de Moraes Holschuh wrote:
    > > On Mon, 22 Feb 2010, Clemens Ladisch wrote:
    > > > Fix up the volume status setting functions to return a non-zero value if
    > > > the control value has changed, so that the ALSA framework can correctly
    > > > generate control change notifications.
    > >
    > > Please explain...
    > ALSA sends notifications to all mixer application when the value of
    > any mixer control has changed. To be able to avoid sending them for
    > controls that did not actually change, it uses the return value of the
    > .put callback: 0 means the control value did not change; 1 means it has
    > changed (or might have changed), and a notification is to be sent.
    > <>

    I am looking at it. I think I had it like that on purpose, to trigger an
    OSD when a volume-related hotkey is pressed even if it doesn't change the
    state (mute when already mute, vol down when already at minimum, etc).

    "One disk to rule them all, One disk to find them. One disk to bring
    them all and in the darkness grind them. In the Land of Redmond
    where the shadows lie." -- The Silicon Valley Tarot
    Henrique Holschuh

     \ /
      Last update: 2010-02-26 01:33    [W:0.023 / U:1.176 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site