lkml.org 
[lkml]   [2010]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf/scripts: Fix supported language listing option
    Commit-ID:  f526d68b6ce9ba7a2bd94e663e240a022524c58a
    Gitweb: http://git.kernel.org/tip/f526d68b6ce9ba7a2bd94e663e240a022524c58a
    Author: Tom Zanussi <tzanussi@gmail.com>
    AuthorDate: Wed, 27 Jan 2010 02:27:52 -0600
    Committer: Frederic Weisbecker <fweisbec@gmail.com>
    CommitDate: Tue, 23 Feb 2010 20:34:42 +0100

    perf/scripts: Fix supported language listing option

    'perf trace -s list' prints a list of the supported scripting
    languages. One problem with it is that it falls through and prints
    the trace as well. The use of 'list' for this also makes it easy to
    confuse with 'perf trace -l', used for listing available scripts. So
    change 'perf trace -s list' to 'perf trace -s lang' and fixes the
    fall-through problem.

    Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Keiichi KII <k-keiichi@bx.jp.nec.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    LKML-Reference: <1264580883-15324-2-git-send-email-tzanussi@gmail.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    tools/perf/Documentation/perf-trace.txt | 4 +++-
    tools/perf/builtin-trace.c | 4 ++--
    2 files changed, 5 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt
    index 60e5900..c00a76f 100644
    --- a/tools/perf/Documentation/perf-trace.txt
    +++ b/tools/perf/Documentation/perf-trace.txt
    @@ -45,9 +45,11 @@ OPTIONS
    --list=::
    Display a list of available trace scripts.

    --s::
    +-s ['lang']::
    --script=::
    Process trace data with the given script ([lang]:script[.ext]).
    + If the string 'lang' is specified in place of a script name, a
    + list of supported languages will be displayed instead.

    -g::
    --gen-script=::
    diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
    index 0b65779..d5d20c3 100644
    --- a/tools/perf/builtin-trace.c
    +++ b/tools/perf/builtin-trace.c
    @@ -219,9 +219,9 @@ static int parse_scriptname(const struct option *opt __used,
    const char *script, *ext;
    int len;

    - if (strcmp(str, "list") == 0) {
    + if (strcmp(str, "lang") == 0) {
    list_available_languages();
    - return 0;
    + exit(0);
    }

    script = strchr(str, ':');

    \
     
     \ /
      Last update: 2010-02-25 11:09    [W:0.025 / U:91.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site