lkml.org 
[lkml]   [2010]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -tip v3&10 13/18] perf probe: Rename probe finder functions
    Date
    Rename *_probepoint to *_probe_point, for nothing
    but a cosmetic reason.

    Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: K.Prasad <prasad@linux.vnet.ibm.com>
    ---

    tools/perf/builtin-probe.c | 2 +-
    tools/perf/util/probe-finder.c | 12 ++++++------
    tools/perf/util/probe-finder.h | 2 +-
    3 files changed, 8 insertions(+), 8 deletions(-)

    diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
    index c7e14d0..c3e6119 100644
    --- a/tools/perf/builtin-probe.c
    +++ b/tools/perf/builtin-probe.c
    @@ -314,7 +314,7 @@ int cmd_probe(int argc, const char **argv, const char *prefix __used)
    continue;

    lseek(fd, SEEK_SET, 0);
    - ret = find_probepoint(fd, pp);
    + ret = find_probe_point(fd, pp);
    if (ret > 0)
    continue;
    if (ret == 0) { /* No error but failed to find probe point. */
    diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
    index 3e10dbe..c819fd5 100644
    --- a/tools/perf/util/probe-finder.c
    +++ b/tools/perf/util/probe-finder.c
    @@ -524,8 +524,8 @@ static void free_current_frame_base(struct probe_finder *pf)
    }

    /* Show a probe point to output buffer */
    -static void show_probepoint(Dwarf_Die sp_die, Dwarf_Signed offs,
    - struct probe_finder *pf)
    +static void show_probe_point(Dwarf_Die sp_die, Dwarf_Signed offs,
    + struct probe_finder *pf)
    {
    struct probe_point *pp = pf->pp;
    char *name;
    @@ -585,7 +585,7 @@ static int probeaddr_callback(struct die_link *dlink, void *data)
    /* Check the address is in this subprogram */
    if (tag == DW_TAG_subprogram &&
    die_within_subprogram(dlink->die, pf->addr, &offs)) {
    - show_probepoint(dlink->die, offs, pf);
    + show_probe_point(dlink->die, offs, pf);
    return 1;
    }
    return 0;
    @@ -668,7 +668,7 @@ static int probefunc_callback(struct die_link *dlink, void *data)
    pf->addr = die_get_entrypc(dlink->die);
    pf->addr += pp->offset;
    /* TODO: Check the address in this function */
    - show_probepoint(dlink->die, pp->offset, pf);
    + show_probe_point(dlink->die, pp->offset, pf);
    return 1; /* Exit; no same symbol in this CU. */
    }
    } else if (tag == DW_TAG_inlined_subroutine && pf->inl_offs) {
    @@ -691,7 +691,7 @@ found:
    /* Get offset from subprogram */
    ret = die_within_subprogram(lk->die, pf->addr, &offs);
    DIE_IF(!ret);
    - show_probepoint(lk->die, offs, pf);
    + show_probe_point(lk->die, offs, pf);
    /* Continue to search */
    }
    }
    @@ -704,7 +704,7 @@ static void find_probe_point_by_func(struct probe_finder *pf)
    }

    /* Find a probe point */
    -int find_probepoint(int fd, struct probe_point *pp)
    +int find_probe_point(int fd, struct probe_point *pp)
    {
    Dwarf_Half addr_size = 0;
    Dwarf_Unsigned next_cuh = 0;
    diff --git a/tools/perf/util/probe-finder.h b/tools/perf/util/probe-finder.h
    index 972b386..b2a2524 100644
    --- a/tools/perf/util/probe-finder.h
    +++ b/tools/perf/util/probe-finder.h
    @@ -52,7 +52,7 @@ struct line_range {
    };

    #ifndef NO_LIBDWARF
    -extern int find_probepoint(int fd, struct probe_point *pp);
    +extern int find_probe_point(int fd, struct probe_point *pp);
    extern int find_line_range(int fd, struct line_range *lr);

    /* Workaround for undefined _MIPS_SZLONG bug in libdwarf.h: */

    --
    Masami Hiramatsu

    Software Engineer
    Hitachi Computer Products (America), Inc.
    Software Solutions Division

    e-mail: mhiramat@redhat.com


    \
     
     \ /
      Last update: 2010-02-25 14:39    [W:0.029 / U:5.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site