Messages in this thread | | | Date | Wed, 24 Feb 2010 14:58:22 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] cs5535_gpio: gpio_chip.get should return the input value |
| |
On Tue, 23 Feb 2010 16:55:17 -0600 Ben Gardner <gardner.ben@gmail.com> wrote:
> The gpio_chip.get() function for the CS5535 GPIO driver currently returns the > output value instead of the input value. > This patch changes it to return the input value. > > Signed-off-by: Ben Gardner <gardner.ben@gmail.com> > --- > --- linux-2.6.33-rc8.orig/drivers/gpio/cs5535-gpio.c > +++ linux-2.6.33-rc8/drivers/gpio/cs5535-gpio.c > @@ -154,7 +154,7 @@ > > static int chip_gpio_get(struct gpio_chip *chip, unsigned offset) > { > - return cs5535_gpio_isset(offset, GPIO_OUTPUT_VAL); > + return cs5535_gpio_isset(offset, GPIO_READ_BACK); > } > > static void chip_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
<presses F10>
What were the user-visible effects of this bug?
| |