lkml.org 
[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] driver-core: Add device node pointer to struct device
    On Wed, Feb 24, 2010 at 03:09:24PM -0700, Grant Likely wrote:
    > On Wed, Feb 24, 2010 at 2:44 PM, Greg KH <gregkh@suse.de> wrote:
    > > On Wed, Feb 24, 2010 at 02:10:30PM -0700, Grant Likely wrote:
    > >> Greg and Kay,
    > >>
    > >> This is a patch from a larger series of OF related cleanup patches.  This
    > >> one adds a new 'of_node' member to struct device, conditional upon
    > >> CONFIG_OF.  The goal is to move of_node out of archdata because all
    > >> arches using CONFIG_OF need it.
    > >>
    > >> Before I commit too much effort down this path, I want to get your
    > >> feedback.  Do you have any objections to this change to struct device?
    > >>
    > >> @@ -414,6 +415,9 @@ struct device {
    > >>                                            override */
    > >>       /* arch specific additions */
    > >>       struct dev_archdata     archdata;
    > >> +#ifdef CONFIG_OF
    > >> +     struct device_node      *of_node;
    > >> +#endif
    > >
    > > No objection from me, but do we really need the #ifdef here?
    >
    > I added the #ifdef because it is complete dead weight when CONFIG_OF
    > is not set. However, I'll defer to your preference here on what looks
    > cleaner w.r.t. maintenance.

    Ok, you can leave it as-is, that's not a problem. As long as we don't
    have to #ifdef the core code, it should be fine.

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-24 23:41    [W:0.042 / U:94.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site