lkml.org 
[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] OMAP: Dereference of NULL autodep in _autodep_lookup()
    > Thanks for the patch, but I don't understand what problem you're
    > pointing out.  If autodeps is NULL entering clkdm_init(), then the
    > for-loop won't even be entered.

    My first patch was wrong, but there's something I think could
    be wrong. In clkdm_init() we have:

    for (autodep = autodeps; autodep->pwrdm.ptr; autodep++)
    _autodep_lookup(autodep);

    In _autodep_lookup() we ensure that we don't dereference
    autodep by:

    if (!autodep)
    return;

    but if autodep can be NULL we already dereferenced it in
    the aforementioned for loop, so shouldn't that be:

    for (autodep = autodeps; autodep && autodep->pwrdm.ptr; autodep++)
    _autodep_lookup(autodep);

    Then since this is the only call to _autodep_lookup() we can remove
    that test there. Do you agree?

    > It looks like there may be a problem, however, in _clkdm_add_autodeps()
    > and _clkdm_del_autodeps() if no autodeps were passed in.  What do you
    > think about something like the following instead?
    >
    >
    > - Paul

    Your suggested patch looks right to me as well.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-24 23:27    [W:0.023 / U:88.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site