[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging
On 02/24/2010 10:00 PM, Alexander Graf wrote:
> On 24.02.2010, at 20:58, Avi Kivity wrote:
>> On 02/24/2010 09:37 PM, Joerg Roedel wrote:
>>>> Isn't there such a list around somewhere already? We really should
>>>> only keep this list once throughout the whole code. If necessary, just
>>>> create the list on the fly when bits get set in the msrpm.
>>> No, the list is hardcoded in 3 functions (as parameter of
>>> set_msr_interception). I think about a variant to do this with a single
>>> list. Probably I create a list of MSRs and check in
>>> set_msr_interceptionm for it.
>> Or, have set_msr_interception() create the list of offsets.
> Or even better yet put the list into BSS because it should be static anyways. From that the real MSRPM and the merging function can be fed.


In fact, the real MSRPM can be generated by merging the list into an
empty bitmap.

Do not meddle in the internals of kernels, for they are subtle and quick to panic.

 \ /
  Last update: 2010-02-24 21:13    [W:0.036 / U:4.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site