| Date | Wed, 24 Feb 2010 12:11:33 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 07/14] Regulators: lp3971 - fail if platform data was not supplied |
| |
On Tue, Feb 23, 2010 at 11:38:17PM -0800, Dmitry Torokhov wrote: > There is no point in completing probe if platform data is missing so > let's abort loading early. > > Also, use kcalloc when allocating several instances of the same data > structure and mark setup_regulators() as __devinit since it is only > called from lp3971_i2c_probe() which is __devinit. > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but this *really* should have been split into multiple patches, there's a large number of different changes mixed in here, with random coding style tweaks overlapping with substantial changes to the handling of probe.
|