lkml.org 
[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner()
Tobias Lorenz wrote:
> Hello Mauro,
>
>>> no, the default value of retval makes no difference to the function.
>>>
>>> Retval is set by si470x_disconnect_check and si470x_set_register.
>>> After each call, retval is checked.
>>> There is no need to reset it passed.
>
>> You may just do then:
>>
>> int retval = si470x_disconnect_check(radio);
>
> In all other set/get functions of v4l2_ioctl_ops in the driver, I just set the default value of retval to 0.
> To be identical in si470x_vidioc_s_tuner, I modified the patch to the one below.
> I already pushed this and another cosmetic patch into mercurial:
>
> http://linuxtv.org/hg/~tlorenz/v4l-dvb/rev/72a2f38d5956
See comment bellow.


> http://linuxtv.org/hg/~tlorenz/v4l-dvb/rev/3efd5d32a618
Applied.

>
> Mauro, can you pull them?

Tobias, next time or send one patch per email or send me a pull request.

>
> Bye,
> Tobias
>
> --- a/linux/drivers/media/radio/si470x/radio-si470x-common.c Thu Feb 11 23:11:30 2010 -0200
> +++ b/linux/drivers/media/radio/si470x/radio-si470x-common.c Thu Feb 18 20:31:33 2010 +0100
> @@ -748,7 +748,7 @@
> struct v4l2_tuner *tuner)
> {
> struct si470x_device *radio = video_drvdata(file);
> - int retval = -EINVAL;
> + int retval = 0;
>
> /* safety checks */
> retval = si470x_disconnect_check(radio);

This really doesn't make any sense. Just do:

int retval = i470x_disconnect_check(radio);

or
int retval;

retval = i470x_disconnect_check(radio);



--

Cheers,
Mauro


\
 
 \ /
  Last update: 2010-02-24 06:15    [from the cache]
©2003-2011 Jasper Spaans