lkml.org 
[lkml]   [2010]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch -mm 3/9 v2] oom: select task from tasklist for mempolicy ooms
    On Tue, 23 Feb 2010, Balbir Singh wrote:

    > > The oom killer presently kills current whenever there is no more memory
    > > free or reclaimable on its mempolicy's nodes. There is no guarantee that
    > > current is a memory-hogging task or that killing it will free any
    > > substantial amount of memory, however.
    > >
    > > In such situations, it is better to scan the tasklist for nodes that are
    > > allowed to allocate on current's set of nodes and kill the task with the
    > > highest badness() score. This ensures that the most memory-hogging task,
    > > or the one configured by the user with /proc/pid/oom_adj, is always
    > > selected in such scenarios.
    > >
    > > Signed-off-by: David Rientjes <rientjes@google.com>
    >
    > Seems reasonable, but I think it will require lots of testing.

    I already tested it by checking that tasks with very elevated oom_adj
    values don't get killed when they do not share the same MPOL_BIND nodes as
    a memory-hogging task.

    What additional testing did you have in mind?


    \
     
     \ /
      Last update: 2010-02-23 09:19    [W:3.256 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site