Messages in this thread | | | Date | Tue, 23 Feb 2010 00:17:26 -0800 (PST) | From | David Rientjes <> | Subject | Re: [patch -mm 3/9 v2] oom: select task from tasklist for mempolicy ooms |
| |
On Tue, 23 Feb 2010, Balbir Singh wrote:
> > The oom killer presently kills current whenever there is no more memory > > free or reclaimable on its mempolicy's nodes. There is no guarantee that > > current is a memory-hogging task or that killing it will free any > > substantial amount of memory, however. > > > > In such situations, it is better to scan the tasklist for nodes that are > > allowed to allocate on current's set of nodes and kill the task with the > > highest badness() score. This ensures that the most memory-hogging task, > > or the one configured by the user with /proc/pid/oom_adj, is always > > selected in such scenarios. > > > > Signed-off-by: David Rientjes <rientjes@google.com> > > Seems reasonable, but I think it will require lots of testing.
I already tested it by checking that tasks with very elevated oom_adj values don't get killed when they do not share the same MPOL_BIND nodes as a memory-hogging task.
What additional testing did you have in mind?
| |