Messages in this thread | | | Date | Tue, 23 Feb 2010 10:07:41 -0500 | From | Don Zickus <> | Subject | Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlier patches |
| |
On Tue, Feb 23, 2010 at 02:24:27AM +0300, Cyrill Gorcunov wrote: > On Mon, Feb 22, 2010 at 06:09:03PM -0500, Don Zickus wrote: > ... > > Hi Don! > > > diff --git a/kernel/nmi_watchdog.c b/kernel/nmi_watchdog.c > > index 3c75cbf..0a6f57f 100644 > > --- a/kernel/nmi_watchdog.c > > +++ b/kernel/nmi_watchdog.c > > @@ -50,31 +50,31 @@ void touch_all_nmi_watchdog(void) > > > > static int __init setup_nmi_watchdog(char *str) > > { > > - if (!strncmp(str, "panic", 5)) { > > - panic_on_timeout = 1; > > - str = strchr(str, ','); > > - if (!str) > > - return 1; > > - ++str; > > - } > > - return 1; > > + if (!strncmp(str, "panic", 5)) { > > + panic_on_timeout = 1; > > If I understand all the things correct -- you don't need to check for ',' > after panic. It seems so. Because we're switching to perf_events I suppose > we may drop expecting "lapic,ioapic" or whatever here? Or there is an idea
ah good point. I was just cutting and pasting things and didn't think to much about it.
> to parse say "panic,software" (ie to switch to software events by default)?
interesting idea, could be useful.
Thanks, Don
| |