lkml.org 
[lkml]   [2010]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/15] MTD: mtdblock: test return value of add_mtd_blktrans_dev, because if can fail
    Date
    This prevents a memory leak

    Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
    ---
    drivers/mtd/mtdblock.c | 3 ++-
    drivers/mtd/mtdblock_ro.c | 3 ++-
    2 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
    index 8e5da1e..7ce30a2 100644
    --- a/drivers/mtd/mtdblock.c
    +++ b/drivers/mtd/mtdblock.c
    @@ -348,7 +348,8 @@ static void mtdblock_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
    if (!(mtd->flags & MTD_WRITEABLE))
    dev->mbd.readonly = 1;

    - add_mtd_blktrans_dev(&dev->mbd);
    + if (add_mtd_blktrans_dev(&dev->mbd))
    + kfree(dev);
    }

    static void mtdblock_remove_dev(struct mtd_blktrans_dev *dev)
    diff --git a/drivers/mtd/mtdblock_ro.c b/drivers/mtd/mtdblock_ro.c
    index 54ff288..d0d3f79 100644
    --- a/drivers/mtd/mtdblock_ro.c
    +++ b/drivers/mtd/mtdblock_ro.c
    @@ -43,7 +43,8 @@ static void mtdblock_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
    dev->tr = tr;
    dev->readonly = 1;

    - add_mtd_blktrans_dev(dev);
    + if (add_mtd_blktrans_dev(dev))
    + kfree(dev);
    }

    static void mtdblock_remove_dev(struct mtd_blktrans_dev *dev)
    --
    1.6.3.3


    \
     
     \ /
      Last update: 2010-02-22 19:43    [W:0.021 / U:59.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site