lkml.org 
[lkml]   [2010]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] memcg: dirty pages instrumentation
    On Mon, Feb 22, 2010 at 09:32:21AM +0900, KAMEZAWA Hiroyuki wrote:
    > > - if (vm_dirty_bytes)
    > > - dirty = DIV_ROUND_UP(vm_dirty_bytes, PAGE_SIZE);
    > > + dirty_bytes = mem_cgroup_dirty_bytes();
    > > + if (dirty_bytes)
    > > + dirty = DIV_ROUND_UP(dirty_bytes, PAGE_SIZE);
    > > else {
    > > int dirty_ratio;
    >
    > you use local value. But, if hierarchila accounting used, memcg->dirty_bytes
    > should be got from root-of-hierarchy memcg.
    >
    > I have no objection if you add a pointer as
    > memcg->subhierarchy_root
    > to get root of hierarchical accounting. But please check problem of hierarchy, again.

    Right, it won't work with hierarchy. I'll fix also considering the
    hierarchy case.

    Thanks for your review.

    -Andrea


    \
     
     \ /
      Last update: 2010-02-22 18:59    [W:0.018 / U:94.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site