[lkml]   [2010]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/1] ftrace - add support for tracing_thresh to function_graph tracer
    On Sat, 2010-02-20 at 15:21 +0100, Frederic Weisbecker wrote:

    > Actually why do we encumber with both tracing_thresh and the funcgraph-exit
    > option?
    > We could just have the output and the record check tracing_thresh instead
    > of the funcgraph-exit option.

    You mean just use tracing_thresh during the tracing? We could perhaps
    also change the code (and I think this would be beneficial even without
    this change) to print the function on exit if it did not have a entry.

    That is, in the reading of the trace, keep a depth pointer. For every
    "entry" we hit, we add one, and for every "exit" we subtract one (per
    cpu). If we go negative, we keep the counter at zero, but write
    something like:

    } (sys_write)

    Because I always hate it when a trace starts with a bunch of "}" and I
    have no idea what functions they are. This would fix that.

    Yeah, Tim's trace would have only "} (sys_write)" type syntax but that's
    probably fine.

    -- Steve

     \ /
      Last update: 2010-02-22 15:51    [W:0.047 / U:33.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site