Messages in this thread | | | Date | Mon, 22 Feb 2010 09:23:03 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic |
| |
Frederic Weisbecker wrote: > On Thu, Feb 18, 2010 at 11:19:54AM -0500, Masami Hiramatsu wrote: >>> For now it is stored is asm/ptrace.h, but that might be split in >>> the future, especially as ptrace has initially nothing related to >>> that. A documentation that deals with filenames or API enumerations >>> tend to be incidentally async with API evolutions. >> >> yeah, now those APIs depend on pt_regs, so I put it in ptrace.h. >> >> Thank you, > > > Are you guys fine with the following patch or should I bring > more details somewhere?
I'm fine with it :-)
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
> > Thanks. > > --- > commit d3643132cfeac24ee20d2b6cd8cb06d73e6a6da9 > Author: Heiko Carstens <heiko.carstens@de.ibm.com> > Date: Thu Feb 18 14:25:21 2010 +0100 > > tracing/kprobes: Add short documentation for HAVE_REGS_AND_STACK_ACCESS_API > > So that arch developers know how to implement it without the > need to dig into changelogs. > > Reported-by: Mike Frysinger <vapier.adi@gmail.com> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > Cc: Masami Hiramatsu <mhiramat@redhat.com> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: "David S . Miller" <davem@davemloft.net> > Cc: Paul Mundt <lethal@linux-sh.org> > Cc: Steven Rostedt <rostedt@goodmis.org> > LKML-Reference: <20100218132521.GB2406@osiris.boeblingen.de.ibm.com> > [added reference to ptrace.h in the config help] > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > > diff --git a/arch/Kconfig b/arch/Kconfig > index 04e3aa7..50877ef 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -123,6 +123,11 @@ config USE_GENERIC_SMP_HELPERS > > config HAVE_REGS_AND_STACK_ACCESS_API > bool > + help > + This symbol should be selected by an architecure if it supports > + the API needed to access registers and stack entries from pt_regs, > + declared in asm/ptrace.h > + For example the kprobes-based event tracer needs this API. > > config HAVE_CLK > bool > >
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |