Messages in this thread | | | Date | Sat, 20 Feb 2010 21:54:31 +0800 | From | Américo Wang <> | Subject | Re: sysfs lockdep complaint |
| |
On Sat, Feb 20, 2010 at 12:13:49PM +0100, Johannes Berg wrote: >On Sat, 2010-02-20 at 17:26 +0800, Américo Wang wrote: > >> This should be fixed by the patchset from Eric: >> >> http://lkml.org/lkml/2010/2/11/334 > >That patchset doesn't even compile. >
Wow. I didn't notice that.
Eric, could you fix your last patch? I mean your patch 4/4, probably.
Greg?
>johannes > >--- > drivers/pci/pci-sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >--- wireless-testing.orig/drivers/pci/pci-sysfs.c 2010-02-20 12:12:28.207979616 +0100 >+++ wireless-testing/drivers/pci/pci-sysfs.c 2010-02-20 12:12:54.588603464 +0100 >@@ -642,7 +642,7 @@ void pci_create_legacy_files(struct pci_ > if (!b->legacy_io) > goto kzalloc_err; > >- sysfs_bin_attr_init(&b->legacy_io); >+ sysfs_bin_attr_init(b->legacy_io); > b->legacy_io->attr.name = "legacy_io"; > b->legacy_io->size = 0xffff; > b->legacy_io->attr.mode = S_IRUSR | S_IWUSR; >@@ -655,8 +655,8 @@ void pci_create_legacy_files(struct pci_ > goto legacy_io_err; > > /* Allocated above after the legacy_io struct */ >- sysfs_bin_attr_init(&b->legacy_mem); > b->legacy_mem = b->legacy_io + 1; >+ sysfs_bin_attr_init(b->legacy_mem); > b->legacy_mem->attr.name = "legacy_mem"; > b->legacy_mem->size = 1024*1024; > b->legacy_mem->attr.mode = S_IRUSR | S_IWUSR; > >
-- Live like a child, think like the god.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |