lkml.org 
[lkml]   [2010]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: sysfs lockdep complaint
    On Sat, Feb 20, 2010 at 04:08:16PM +0100, Johannes Berg wrote:
    >On Sat, 2010-02-20 at 23:03 +0800, Américo Wang wrote:
    >
    >> fct->fan_type = pwm_fan;
    >> fct->ctrl.type = pwm_fan ? WF_CONTROL_PWM_FAN : WF_CONTROL_RPM_FAN;
    >> + sysfs_attr_init(&fct->ctrl.attr);
    >
    >ah, needs to be "ctrl.attr.attr".
    >

    Ouch, right... Updated.

    Thank you!


    ---
    diff --git a/drivers/macintosh/windfarm_smu_controls.c b/drivers/macintosh/windfarm_smu_controls.c
    index 6c68b9e..5f4e5a0 100644
    --- a/drivers/macintosh/windfarm_smu_controls.c
    +++ b/drivers/macintosh/windfarm_smu_controls.c
    @@ -173,6 +173,7 @@ static struct smu_fan_control *smu_fan_create(struct device_node *node,

    fct->fan_type = pwm_fan;
    fct->ctrl.type = pwm_fan ? WF_CONTROL_PWM_FAN : WF_CONTROL_RPM_FAN;
    + sysfs_attr_init(&fct->ctrl.attr.attr);

    /* We use the name & location here the same way we do for SMU sensors,
    * see the comment in windfarm_smu_sensors.c. The locations are a bit
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2010-02-20 16:19    [W:0.021 / U:0.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site