Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 07/18] sysctl extern cleanup - compat | Date | Sat, 20 Feb 2010 15:51:56 +0100 |
| |
On Saturday 20 February 2010 15:13:28 Dave Young wrote: > Extern declarations in sysctl.c should be move to their own head file, > and then include them in relavant .c files. > > Move compat_log extern declaration to linux/compat.h > > Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Good idea in principle, but please don't enclose the extern declaration in #ifdef:
> --- linux-2.6.32.orig/include/linux/compat.h 2010-02-20 14:02:24.334925488 +0800 > +++ linux-2.6.32/include/linux/compat.h 2010-02-20 14:24:30.405627048 +0800 > @@ -17,6 +17,9 @@ > #include <asm/siginfo.h> > #include <asm/signal.h> > > +#ifdef CONFIG_SYSCTL > +extern int compat_log; > +#endif > #define compat_jiffies_to_clock_t(x) \ > (((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
This will force a rebuild of everything that #includes linux/compat.h when CONFIG_SYSCTL changes, while nothing really changes.
Obviously, the same goes for the entire series.
Arnd
| |