Messages in this thread | | | Date | Tue, 2 Feb 2010 15:25:10 -0600 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH] syslog: distinguish between /proc/kmsg and syscalls |
| |
Quoting Kees Cook (kees.cook@canonical.com): > Hi, > > On Mon, Feb 01, 2010 at 10:15:06PM -0800, Casey Schaufler wrote: > > Might I suggest that you use a term other than "context" in this patch? > > I recognize that it is the proper word, but the term has significant and > > specific meaning in SELinux, and some of that has spilled over into the > > LSM in general. I expect that there might be confusion if it is used to > > denote something other than an SELinux "context". Perhaps "method", "type", > > or "scheme". > > Yeah, I cringed at "context" too, but since "type" is pretty overloaded > and it was already an argument there, I figured maybe it wouldn't be > too bad. > > > > -extern int cap_syslog(int type); > > > +extern int cap_syslog(int type, int context); > > Perhaps "source" or "origin"? "mode" is too overloaded with file modes. > Maybe a future patch can change "type" to "action" too.
'int from_file' or 'int from_sysc'?
Really the special case is that if (from_file) then we take the file as a validated token allowing us to bypass new privilege checks, right? so 'from_file' seems appropriate to me.
-serge
| |