lkml.org 
[lkml]   [2010]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] hrtimer, softirq: Fix hrtimer->softirq trampoline
    From
    Date
    On Tue, 2010-02-02 at 09:28 -0500, Yury Polyanskiy wrote:
    > On Tue, 02 Feb 2010 15:20:01 +0100
    > Peter Zijlstra <peterz@infradead.org> wrote:
    > > static enum hrtimer_restart __hrtimer_tasklet_trampoline(struct hrtimer *timer)
    > > {
    > > struct tasklet_hrtimer *ttimer =
    > > container_of(timer, struct tasklet_hrtimer, timer);
    > >
    > > - if (hrtimer_is_hres_active(timer)) {
    > > - tasklet_hi_schedule(&ttimer->tasklet);
    > > - return HRTIMER_NORESTART;
    > > - }
    > > - return ttimer->function(timer);
    > > + tasklet_hi_schedule(&ttimer->tasklet);
    > > + return HRTIMER_NORESTART;
    > > }
    > >
    >
    > Are you totally against if(in_irq())?

    Yeah, things like that are an indication that you really don't know wtf
    you're doing and are just patching up.

    There is a single site where hrtimer callbacks can indeed be done from
    softirq, but in that case the above still works correctly, and I've been
    meaning to get rid of that anyway.





    \
     
     \ /
      Last update: 2010-02-02 15:39    [W:0.027 / U:0.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site