[lkml]   [2010]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 10/10] sound/soc/blackfin: Fix continuation line formats
    On Mon, Feb 01, 2010 at 11:13:04PM -0500, Mike Frysinger wrote:
    > On Mon, Feb 1, 2010 at 12:08, Joe Perches wrote:

    > > There are a few false positives and probably a few missing using

    > >        grep -rP --include=*.[ch] '".*\\$' * | \
    > >        awk '{ if ((gsub("\"", "\"") % 2) == 1) print $0; }'

    > > Most of the uses are __asm__ __volatile__ which could be
    > > considered unsightly but don't impact logging messages.

    > > The rest could/should be fixed.

    My point was that it'd be good to also check for just regular use of
    continuations in code other than macro definitions. These are just a
    style nit but if there's a script that filters out false positives from
    the macros that'd be handy...

    > the Blackfin alsa fixes all look good to me, thanks

    Running "grep ' \\$' sound/soc/blackfin/*.[ch]" suggests that there's
    still some of the continuations I mentioned above in there (plus a lot
    of false positives from macros).
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2010-02-02 12:11    [W:0.019 / U:65.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site