Messages in this thread Patch in this message | | | Date | Fri, 19 Feb 2010 21:00:02 +0100 (CET) | From | Stefan Richter <> | Subject | [PATCH] firewire: core: fix an information leak |
| |
If a device exposes a sparsely populated configuration ROM, firewire-core's sysfs interface and character device file interface showed random data in the gaps between config ROM blocks. Fix this by zero-initialization of the config ROM reader's scratch buffer.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/firewire/core-device.c | 1 + 1 file changed, 1 insertion(+)
Index: b/drivers/firewire/core-device.c =================================================================== --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -514,6 +514,7 @@ static int read_bus_info_block(struct fw return -ENOMEM; stack = &rom[READ_BIB_ROM_SIZE]; + memset(rom, 0, sizeof(*rom) * READ_BIB_ROM_SIZE); device->max_speed = SCODE_100; -- Stefan Richter -=====-==-=- --=- =--== http://arcgraph.de/sr/
| |