lkml.org 
[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 2/7] vsprintf: clarify comments for printf_spec flags
    On 02/19/10 09:58, Bjorn Helgaas wrote:
    >
    > Add clues about what the SMALL and SPECIAL flags do.
    >
    > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
    > ---
    >
    > lib/vsprintf.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    >
    > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
    > index 3b8aeec..212d047 100644
    > --- a/lib/vsprintf.c
    > +++ b/lib/vsprintf.c
    > @@ -381,8 +381,8 @@ static noinline char *put_dec(char *buf, unsigned long long num)
    > #define PLUS 4 /* show plus */
    > #define SPACE 8 /* space if plus */
    > #define LEFT 16 /* left justified */
    > -#define SMALL 32 /* Must be 32 == 0x20 */
    > -#define SPECIAL 64 /* 0x */
    > +#define SMALL 32 /* use lowercase in hex (must be 32 == 0x20) */
    > +#define SPECIAL 64 /* prefix hex with "0x", octal with "0 */

    might as well do: octal with "0" */


    >
    > enum format_type {
    > FORMAT_TYPE_NONE, /* Just a string part */


    --
    ~Randy


    \
     
     \ /
      Last update: 2010-02-19 19:09    [W:0.027 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site