lkml.org 
[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[01/93] Fix potential crash with sys_move_pages
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Linus Torvalds <torvalds@linux-foundation.org>

    commit 6f5a55f1a6c5abee15a0e878e5c74d9f1569b8b0 upstream.

    We incorrectly depended on the 'node_state/node_isset()' functions
    testing the node range, rather than checking it explicitly. That's not
    reliable, even if it might often happen to work. So do the proper
    explicit test.

    Reported-by: Marcus Meissner <meissner@suse.de>
    Acked-and-tested-by: Brice Goglin <Brice.Goglin@inria.fr>
    Acked-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    mm/migrate.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/mm/migrate.c
    +++ b/mm/migrate.c
    @@ -953,6 +953,9 @@ static int do_pages_move(struct mm_struc
    goto out_pm;

    err = -ENODEV;
    + if (node < 0 || node >= MAX_NUMNODES)
    + goto out_pm;
    +
    if (!node_state(node, N_HIGH_MEMORY))
    goto out_pm;




    \
     
     \ /
      Last update: 2010-02-19 18:21    [W:0.021 / U:181.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site