lkml.org 
[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[64/93] dst: call cond_resched() in dst_gc_task()
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Eric Dumazet <eric.dumazet@gmail.com>

    commit 2fc1b5dd99f66d93ffc23fd8df82d384c1a354c8 upstream.

    Kernel bugzilla #15239

    On some workloads, it is quite possible to get a huge dst list to
    process in dst_gc_task(), and trigger soft lockup detection.

    Fix is to call cond_resched(), as we run in process context.

    Reported-by: Pawel Staszewski <pstaszewski@itcare.pl>
    Tested-by: Pawel Staszewski <pstaszewski@itcare.pl>
    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/core/dst.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/core/dst.c
    +++ b/net/core/dst.c
    @@ -17,6 +17,7 @@
    #include <linux/string.h>
    #include <linux/types.h>
    #include <net/net_namespace.h>
    +#include <linux/sched.h>

    #include <net/dst.h>

    @@ -79,6 +80,7 @@ loop:
    while ((dst = next) != NULL) {
    next = dst->next;
    prefetch(&next->next);
    + cond_resched();
    if (likely(atomic_read(&dst->__refcnt))) {
    last->next = dst;
    last = dst;



    \
     
     \ /
      Last update: 2010-02-19 18:03    [W:0.023 / U:60.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site