Messages in this thread Patch in this message | | | Subject | Re: printk_ratelimited() not compiling | From | Joe Perches <> | Date | Thu, 18 Feb 2010 14:28:30 -0800 |
| |
On Thu, 2010-02-18 at 14:10 -0800, john stultz wrote: > I thought printk_ratelimited would be perfect for an issue I'm > having, but when I tried using it, replacing a printk I had, I got the > following:
[]
> fs/namei.c:1075: error: variable ‘_rs’ has initializer but incomplete type
[]
> Am I missing something obvious, or did something get broken after this went in?
Dunno. Maybe you typed printk_ratelimit not printk_ratelimited? Can you send the code you're using?
I just tried it in drivers/net/tg3.c and it compiled fine.
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 7f82b02..cf9b0d8 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -1092,7 +1092,7 @@ static int tg3_mdio_init(struct tg3 *tp) i = mdiobus_register(tp->mdio_bus); if (i) { - printk(KERN_WARNING "%s: mdiobus_reg failed (0x%x)\n", + printk_ratelimited(KERN_WARNING "%s: mdiobus_reg failed (0x%x)\n tp->dev->name, i); mdiobus_free(tp->mdio_bus); return i;
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |