Messages in this thread | | | Date | Thu, 18 Feb 2010 09:45:52 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH v2 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge |
| |
On 02/18/10 09:42, Denis Turischev wrote: > Intel Poulsbo (SCH) chipset LPC bridge controller contains several > functions. Creating and MFD driver for the LPC bridge controller allows > simultaneous use of SMBus and GPIO interfaces on the SCH. > > v2 version contains "select MFD_CORE" line. > > Signed-off-by: Denis Turischev <denis@compulab.co.il> > > diff -Nru linux-2.6.33-rc7.orig/drivers/mfd/Kconfig > linux-2.6.33-rc7/drivers/mfd/Kconfig > --- linux-2.6.33-rc7.orig/drivers/mfd/Kconfig 2010-02-07 > 00:17:12.000000000 +0200 > +++ linux-2.6.33-rc7/drivers/mfd/Kconfig 2010-02-18 > 19:32:01.000000000 +0200 > @@ -348,6 +348,15 @@ > read/write functions for the devices to get access to this chip. > This chip embeds various other multimedia funtionalities as well. > > +config LPC_SCH > + tristate "Intel SCH LPC" > + default m
Please don't default random modules to be enabled/built. That could be done via defconfig .. if at all.
> + depends on PCI > + select MFD_CORE > + help > + LPC bridge function of the Intel SCH provides support for > + System Management Bus and General Purpose I/O. > + > endmenu > > menu "Multimedia Capabilities Port drivers"
-- ~Randy
| |