lkml.org 
[lkml]   [2010]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next PATCH v4 2/3] net: TCP thin linear timeouts
On 02/18/2010 09:41 AM, Ilpo Järvinen wrote:
> On Wed, 17 Feb 2010, David Miller wrote:
>
>> From: Andreas Petlund <apetlund@simula.no>
>> Date: Tue, 16 Feb 2010 15:40:41 +0100
>>
>>> @@ -341,6 +342,8 @@ struct tcp_sock {
>>> u16 advmss; /* Advertised MSS */
>>> u8 frto_counter; /* Number of new acks after RTO */
>>> u8 nonagle; /* Disable Nagle algorithm? */
>>> + u8 thin_lto : 1,/* Use linear timeouts for thin streams */
>>> + thin_undef : 7;
>>>
>>
>> There is now a gap of 3 unused bytes here in this critical
>> core TCP socket data structure.
>>
>> Please either find a way to avoid this hole, or document
>> it with a comment.
>
> There would be multiple bits free for use in both frto_counter and nonagle
> byte.
>

I was playing aroud with this setup:

=========
u8 nonagle : 4,/* Disable Nagle algorithm? */
thin_lto : 1,/* Use linear timeouts for thin streams */
thin_dupack : 1,/* Fast retransmit on first dupack */
thin_undef : 2;
=========

Do you think that would do the trick?

Regards,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-02-18 09:47    [W:0.047 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site