Messages in this thread | | | Date | Wed, 17 Feb 2010 15:40:02 -0800 | From | Greg KH <> | Subject | Re: [PATCH] USB: don't read past config->interface[] if usb_control_msg() fails in usb_reset_configuration() |
| |
On Tue, Feb 09, 2010 at 11:09:45PM +0100, roel kluin wrote: > On Tue, Feb 9, 2010 at 11:01 PM, Sarah Sharp > <sarah.a.sharp@linux.intel.com> wrote: > > On Tue, Feb 09, 2010 at 05:01:53PM +0100, Roel Kluin wrote: > >> After the loop `for (i = 0; i < config->desc.bNumInterfaces; i++)' if no > >> break occurred, i equals config->desc.bNumInterfaces. so if > >> usb_control_msg() failed then after goto reset_old_alts we read from > >> config->interface[config->desc.bNumInterfaces]. > >> We can safely decrement i as well if the break occurred. > >> > >> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > >> Acked-by: Alan Stern <stern@rowland.harvard.edu> > > > > Bah, yes, you're right. :) Good catch. > > Could you please confirm whether this patch is the better or the > other (in this same thread)?
Can someone tell me which one is the correct one to apply, but resending it to me?
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |