Messages in this thread | | | Date | Wed, 17 Feb 2010 22:35:46 +0100 (CET) | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH 4/4] V4L/DVB: v4l: document new Bayer and monochrome pixel formats |
| |
On Wed, 17 Feb 2010, Mauro Carvalho Chehab wrote:
> Guennadi, > > Your original patch were against the out-of-tree "media-specs/Makefile", present > only at the -hg tree. > > The way my conversion scripts work is that they'll convert the patches into a > patch that can be applied directly into -git. Among other things, all > changes on files outside the kernel tree are simply discarded by them. > > Also, before patch 2/4, such addition won't be possible. > > So, what happened here is that, after importing from your hg tree, I noticed > -git compilation breakage. So, I ported the autobuild bits for media-entities & co, > manually added the missing pixfmt xml's and removed the duplicate symbol for one > of the bayer standards. > > That's said, I don't really have any preference about the order where the files appear > at the Makefile. I have no objection if you prefer to add them on any other random order. > > In a matter of fact, IMO, the better is to later write a patch that discards > this static list of files, auto-generating it dynamically. > > So, if you really prefer a different order, please re-submit another version for this patch.
No, no problem with me, it doesn't bother me _that_ much;) Thanks for fixing stuff!
Thanks Guennadi --- Guennadi Liakhovetski
| |