Messages in this thread | | | Date | Wed, 17 Feb 2010 18:20:40 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/5] bitops: compile time optimization for hweight_long(CONSTANT) |
| |
On Wed, Feb 17, 2010 at 02:57:42PM +0100, Michal Marek wrote: > On 12.2.2010 20:05, H. Peter Anvin wrote: > > On 02/12/2010 09:47 AM, Borislav Petkov wrote: > >> > >> However, this is generic code and for the above to work we have to > >> enforce x86-specific CFLAGS for it. What is the preferred way to do > >> that? > >> > > > > That's a question for Michal and the kbuild list. Michal? > > (I was offline last week). > > The _preferred_ way probably is not to do it :), but otherwise you can > set CFLAGS_hweight.o depending on CONFIG_X86(_32|_64), just like you do > in arch/x86/lib/Makefile already.
Wouldn't it be better if we had something like ARCH_CFLAGS_hweight.o which gets set in the arch Makefile instead?
-- Regards/Gruss, Boris.
-- Advanced Micro Devices, Inc. Operating Systems Research Center
| |