lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] staging/vmwgfx: depends on FB
On Tue, Feb 16, 2010 at 03:15:22PM -0800, Randy Dunlap wrote:
> On 02/16/10 15:05, Greg KH wrote:
> > On Tue, Feb 16, 2010 at 02:59:11PM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> vmwfgx uses framebuffer interfaces, so it should depend on FB.
> >> Otherwise it has these build errors (e.g., when CONFIG_FB=m):
> >>
> >> drivers/built-in.o: In function `vmw_fb_close':
> >> (.text+0x97713): undefined reference to `unregister_framebuffer'
> >> drivers/built-in.o: In function `vmw_fb_close':
> >> (.text+0x97754): undefined reference to `framebuffer_release'
> >> drivers/built-in.o: In function `vmw_fb_init':
> >> (.text+0x97e1c): undefined reference to `framebuffer_alloc'
> >> drivers/built-in.o: In function `vmw_fb_init':
> >> (.text+0x9838d): undefined reference to `register_framebuffer'
> >> drivers/built-in.o: In function `vmw_fb_init':
> >> (.text+0x9842a): undefined reference to `framebuffer_release'
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >> ---
> >> drivers/gpu/drm/vmwgfx/Kconfig | 2 +-
> >
> > This is not a drivers/staging/* file, so there's not much I can do with
> > it. It belongs to David Airlie.
>
> OK, I'll resend it to him, thanks.
>
> I think I was confused by drivers/staging/Kconfig:
>
> source "drivers/gpu/drm/vmwgfx/Kconfig"
>
> source "drivers/gpu/drm/nouveau/Kconfig"
>
>
> Why are those lines there??

Because those modules are "hidden" behind the CONFIG_STAGING option.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-02-17 01:05    [W:0.069 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site